Page MenuHomePhabricator

Fix some content/background overflow issues with commit graph lists
ClosedPublic

Authored by epriestley on Aug 12 2020, 3:54 PM.
Tags
None
Referenced Files
F12845914: D21440.diff
Fri, Mar 29, 12:37 AM
Unknown Object (File)
Fri, Mar 1, 5:24 PM
Unknown Object (File)
Feb 19 2024, 7:47 AM
Unknown Object (File)
Jan 31 2024, 2:44 PM
Unknown Object (File)
Jan 31 2024, 12:57 PM
Unknown Object (File)
Jan 31 2024, 12:36 PM
Unknown Object (File)
Jan 20 2024, 5:33 AM
Unknown Object (File)
Jan 16 2024, 1:07 AM
Subscribers
None

Details

Summary

Ref T13552. There are currently some content overflow issues on the graph view where the menu height can exceed the content height and the frame is drawn on a sub-element. Make the frame draw around all the content.

Test Plan

Viewed commit graph history view, saw more sensible UI.

Diff Detail

Repository
rP Phabricator
Branch
publish18
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24835
Build 34264: Run Core Tests
Build 34263: arc lint + arc unit

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 12 2020, 3:55 PM
Harbormaster failed remote builds in B24834: Diff 51019!
This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2020, 4:04 PM
This revision was automatically updated to reflect the committed changes.