Page MenuHomePhabricator

Fix some content/background overflow issues with commit graph lists
ClosedPublic

Authored by epriestley on Aug 12 2020, 3:54 PM.

Details

Summary

Ref T13552. There are currently some content overflow issues on the graph view where the menu height can exceed the content height and the frame is drawn on a sub-element. Make the frame draw around all the content.

Test Plan

Viewed commit graph history view, saw more sensible UI.

Diff Detail

Repository
rP Phabricator
Branch
publish18
Lint
Lint OK
Unit
Unit Test Errors
Build Status
Buildable 24834
Build 34262: Run Core Tests
Build 34261: arc lint + arc unit

Unit TestsFailed

TimeTest
286 msPhabricatorCelerityTestCase::testCelerityMaps
Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:32): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it. ACTUAL VALUE
202 msPhabricatorCelerityTestCase::testCelerityMaps
Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:32): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it. ACTUAL VALUE
0 msAlmanacNamesTestCase::testServiceOrDeviceNames
30 assertions passed.
0 msAlmanacServiceTypeTestCase::testGetAllServiceTypes
1 assertion passed.
0 msAphrontHTTPHeaderParserTestCase::testHeaderParser
18 assertions passed.
View Full Test Results (2 Failed · 434 Passed · 2 Skipped)

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 12 2020, 3:55 PM
Harbormaster failed remote builds in B24834: Diff 51019!
This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2020, 4:04 PM
This revision was automatically updated to reflect the committed changes.