Page MenuHomePhabricator
Differential D21440

Fix some content/background overflow issues with commit graph lists
ClosedPublic
Actions

Authored by epriestley on Aug 12 2020, 3:54 PM.
Tags
None
Referenced Files
F14077372: D21440.diff
Thu, Nov 21, 10:58 PM
Unknown Object (File)
Mon, Nov 18, 1:33 PM
Unknown Object (File)
Thu, Nov 14, 7:41 AM
Unknown Object (File)
Sun, Nov 10, 1:46 AM
Unknown Object (File)
Fri, Nov 8, 9:31 PM
Unknown Object (File)
Wed, Nov 6, 1:07 PM
Unknown Object (File)
Fri, Nov 1, 9:06 PM
Unknown Object (File)
Fri, Nov 1, 3:12 AM
View All 93 Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch
Commits
rP429543b6376f: Fix some content/background overflow issues with commit graph lists
Summary

Ref T13552. There are currently some content overflow issues on the graph view where the menu height can exceed the content height and the frame is drawn on a sub-element. Make the frame draw around all the content.

Test Plan

Viewed commit graph history view, saw more sensible UI.

Diff Detail

Repository
rP Phabricator
Branch
publish18
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24835
Build 34264: Run Core Tests
Build 34263: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 12 2020, 3:54 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Aug 12 2020, 3:55 PM
Harbormaster failed remote builds in B24834: Diff 51019!
epriestley updated this revision to Diff 51020.Aug 12 2020, 3:55 PM
  • Fix Celerity map.
Harbormaster completed remote builds in B24835: Diff 51020.Aug 12 2020, 3:57 PM
epriestley requested review of this revision.Aug 12 2020, 3:57 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2020, 4:04 PM
Closed by commit rP429543b6376f: Fix some content/background overflow issues with commit graph lists (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP429543b6376f: Fix some content/background overflow issues with commit graph lists.

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
view/
phui/
34 lines
webroot/
rsrc/
css/
phui/
object-item/
5 lines

Diff 51020

View Options

resources/celerity/map.php

Loading...
View Options

src/view/phui/PHUIObjectItemView.php

Loading...
View Options

webroot/rsrc/css/phui/object-item/phui-oi-list-view.css

Loading...
Phabricator · Built by Phacility