Page MenuHomePhabricator

Revert use of "user-select: all" to modify tab selection behavior
ClosedPublic

Authored by epriestley on Jul 24 2020, 8:40 PM.
Tags
None
Referenced Files
F15442815: D21429.diff
Thu, Mar 27, 12:38 AM
F15415936: D21429.id50989.diff
Thu, Mar 20, 8:29 AM
F15410161: D21429.diff
Wed, Mar 19, 6:50 AM
F15397790: D21429.diff
Sun, Mar 16, 10:18 PM
F15334883: D21429.diff
Sat, Mar 8, 12:58 PM
Unknown Object (File)
Feb 12 2025, 1:57 AM
Unknown Object (File)
Feb 9 2025, 9:48 AM
Unknown Object (File)
Feb 9 2025, 9:48 AM
Subscribers
None

Details

Summary

Reverts D21419. See PHI1814. Previously, I used "user-select: all" to group sequences of spaces for selection.

However, this has a side effect: the sequence is now selected with a single click. I didn't read the docuementation on the CSS property thoroughly and missed this in testing, since I was focused on drag-selection behavior.

This behavior is enough of a net negative that I think we're in a worse state overall; revert it.

Test Plan

Straight revert.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable