Page MenuHomePhabricator

Revert use of "user-select: all" to modify tab selection behavior
ClosedPublic

Authored by epriestley on Jul 24 2020, 8:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 8, 7:00 AM
Unknown Object (File)
Apr 3 2026, 12:57 AM
Unknown Object (File)
Apr 1 2026, 5:11 PM
Unknown Object (File)
Mar 29 2026, 4:39 AM
Unknown Object (File)
Mar 15 2026, 10:22 PM
Unknown Object (File)
Mar 15 2026, 10:51 AM
Unknown Object (File)
Mar 4 2026, 9:33 AM
Unknown Object (File)
Feb 15 2026, 8:54 PM
Subscribers
None

Details

Summary

Reverts D21419. See PHI1814. Previously, I used "user-select: all" to group sequences of spaces for selection.

However, this has a side effect: the sequence is now selected with a single click. I didn't read the docuementation on the CSS property thoroughly and missed this in testing, since I was focused on drag-selection behavior.

This behavior is enough of a net negative that I think we're in a worse state overall; revert it.

Test Plan

Straight revert.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable