Page MenuHomePhabricator

Revert use of "user-select: all" to modify tab selection behavior
ClosedPublic

Authored by epriestley on Jul 24 2020, 8:40 PM.
Tags
None
Referenced Files
F18361064: D21429.diff
Wed, Aug 27, 11:22 AM
F18110315: D21429.id50990.diff
Mon, Aug 11, 6:24 PM
F18105225: D21429.id.diff
Sun, Aug 10, 4:58 PM
F18102966: D21429.diff
Sun, Aug 10, 12:37 AM
F18101251: D21429.diff
Sat, Aug 9, 12:24 PM
F17949311: D21429.id50989.diff
Thu, Jul 31, 11:14 PM
F17939942: D21429.id.diff
Thu, Jul 31, 3:42 AM
F17918763: D21429.diff
Wed, Jul 30, 1:37 AM
Subscribers
None

Details

Summary

Reverts D21419. See PHI1814. Previously, I used "user-select: all" to group sequences of spaces for selection.

However, this has a side effect: the sequence is now selected with a single click. I didn't read the docuementation on the CSS property thoroughly and missed this in testing, since I was focused on drag-selection behavior.

This behavior is enough of a net negative that I think we're in a worse state overall; revert it.

Test Plan

Straight revert.

Diff Detail

Repository
rP Phabricator
Branch
tab2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24807
Build 34224: Run Core Tests
Build 34223: arc lint + arc unit