Page MenuHomePhabricator

Revert use of "user-select: all" to modify tab selection behavior
ClosedPublic

Authored by epriestley on Jul 24 2020, 8:40 PM.
Tags
None
Referenced Files
F19913216: D21429.diff
Fri, Apr 3, 12:57 AM
F19908243: D21429.id50989.diff
Wed, Apr 1, 5:11 PM
F19896722: D21429.id50989.diff
Sun, Mar 29, 4:39 AM
F19874635: D21429.diff
Sun, Mar 15, 10:22 PM
F19871522: D21429.diff
Sun, Mar 15, 10:51 AM
F19813466: D21429.diff
Wed, Mar 4, 9:33 AM
F19749750: D21429.diff
Feb 15 2026, 8:54 PM
F19670005: D21429.id.diff
Feb 7 2026, 10:16 PM
Subscribers
None

Details

Summary

Reverts D21419. See PHI1814. Previously, I used "user-select: all" to group sequences of spaces for selection.

However, this has a side effect: the sequence is now selected with a single click. I didn't read the docuementation on the CSS property thoroughly and missed this in testing, since I was focused on drag-selection behavior.

This behavior is enough of a net negative that I think we're in a worse state overall; revert it.

Test Plan

Straight revert.

Diff Detail

Repository
rP Phabricator
Branch
tab2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24807
Build 34224: Run Core Tests
Build 34223: arc lint + arc unit