Page MenuHomePhabricator

Revert use of "user-select: all" to modify tab selection behavior
ClosedPublic

Authored by epriestley on Jul 24 2020, 8:40 PM.
Tags
None
Referenced Files
F13061932: D21429.diff
Fri, Apr 19, 8:24 PM
Unknown Object (File)
Wed, Apr 17, 3:08 PM
Unknown Object (File)
Thu, Apr 11, 7:17 AM
Unknown Object (File)
Thu, Mar 21, 9:20 AM
Unknown Object (File)
Feb 11 2024, 12:40 AM
Unknown Object (File)
Jan 9 2024, 8:04 AM
Unknown Object (File)
Jan 5 2024, 6:29 PM
Unknown Object (File)
Dec 27 2023, 1:35 PM
Subscribers
None

Details

Summary

Reverts D21419. See PHI1814. Previously, I used "user-select: all" to group sequences of spaces for selection.

However, this has a side effect: the sequence is now selected with a single click. I didn't read the docuementation on the CSS property thoroughly and missed this in testing, since I was focused on drag-selection behavior.

This behavior is enough of a net negative that I think we're in a worse state overall; revert it.

Test Plan

Straight revert.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable