Page MenuHomePhabricator

Revert use of "user-select: all" to modify tab selection behavior
ClosedPublic

Authored by epriestley on Jul 24 2020, 8:40 PM.
Tags
None
Referenced Files
F19813466: D21429.diff
Wed, Mar 4, 9:33 AM
F19749750: D21429.diff
Sun, Feb 15, 8:54 PM
F19670005: D21429.id.diff
Sat, Feb 7, 10:16 PM
F19662138: D21429.diff
Feb 7 2026, 8:15 AM
F19535801: D21429.id50989.diff
Jan 21 2026, 8:28 AM
F19083369: D21429.id50990.diff
Dec 2 2025, 12:34 PM
F18993545: D21429.id50989.diff
Nov 19 2025, 8:10 AM
F18877432: D21429.diff
Nov 6 2025, 8:23 AM
Subscribers
None

Details

Summary

Reverts D21419. See PHI1814. Previously, I used "user-select: all" to group sequences of spaces for selection.

However, this has a side effect: the sequence is now selected with a single click. I didn't read the docuementation on the CSS property thoroughly and missed this in testing, since I was focused on drag-selection behavior.

This behavior is enough of a net negative that I think we're in a worse state overall; revert it.

Test Plan

Straight revert.

Diff Detail

Repository
rP Phabricator
Branch
tab2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24807
Build 34224: Run Core Tests
Build 34223: arc lint + arc unit