Page MenuHomePhabricator

Modernize "Author" and "Committer" rendering for commits
ClosedPublic

Authored by epriestley on Jul 10 2020, 4:16 PM.
Tags
None
Referenced Files
F15412307: D21405.diff
Wed, Mar 19, 12:21 PM
F15411137: D21405.diff
Wed, Mar 19, 8:51 AM
F15410965: D21405.diff
Wed, Mar 19, 8:44 AM
F15410330: D21405.diff
Wed, Mar 19, 7:05 AM
F15382308: D21405.diff
Fri, Mar 14, 11:49 AM
F15334181: D21405.id51022.diff
Sat, Mar 8, 7:23 AM
F15334089: D21405.diff
Sat, Mar 8, 6:44 AM
F15333754: D21405.id50948.diff
Sat, Mar 8, 4:32 AM
Subscribers
None

Details

Summary

Ref T13552. Give "Commit" objects a more modern, identity-aware way to render author and committer information.

This uses handles in a more modern way and gives us a single read callsite for raw author and committer names.

Test Plan
  • Grepped for callers to the old methods, found none. (There are a lot of "renderAuthor()" callers in transactions, but this call takes no parameters.)
  • Viewed some commits, saw sensible lists of authors and committers.

Diff Detail

Repository
rP Phabricator
Branch
publish2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24767
Build 34158: Run Core Tests
Build 34157: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2020, 3:58 PM
This revision was automatically updated to reflect the committed changes.