Page MenuHomePhabricator

Modernize "Author" and "Committer" rendering for commits
ClosedPublic

Authored by epriestley on Jul 10 2020, 4:16 PM.
Tags
None
Referenced Files
F14043842: D21405.diff
Tue, Nov 12, 1:24 PM
F14028383: D21405.diff
Fri, Nov 8, 1:04 PM
F14001237: D21405.id.diff
Fri, Oct 25, 5:29 AM
Unknown Object (File)
Sep 21 2024, 3:09 AM
Unknown Object (File)
Sep 15 2024, 1:09 PM
Unknown Object (File)
Sep 6 2024, 8:22 AM
Unknown Object (File)
Aug 29 2024, 8:23 AM
Unknown Object (File)
Aug 29 2024, 12:42 AM
Subscribers
None

Details

Summary

Ref T13552. Give "Commit" objects a more modern, identity-aware way to render author and committer information.

This uses handles in a more modern way and gives us a single read callsite for raw author and committer names.

Test Plan
  • Grepped for callers to the old methods, found none. (There are a lot of "renderAuthor()" callers in transactions, but this call takes no parameters.)
  • Viewed some commits, saw sensible lists of authors and committers.

Diff Detail

Repository
rP Phabricator
Branch
publish2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24767
Build 34158: Run Core Tests
Build 34157: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2020, 3:58 PM
This revision was automatically updated to reflect the committed changes.