Page MenuHomePhabricator

Modernize "Author" and "Committer" rendering for commits
ClosedPublic

Authored by epriestley on Jul 10 2020, 4:16 PM.

Details

Summary

Ref T13552. Give "Commit" objects a more modern, identity-aware way to render author and committer information.

This uses handles in a more modern way and gives us a single read callsite for raw author and committer names.

Test Plan
  • Grepped for callers to the old methods, found none. (There are a lot of "renderAuthor()" callers in transactions, but this call takes no parameters.)
  • Viewed some commits, saw sensible lists of authors and committers.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2020, 3:58 PM
This revision was automatically updated to reflect the committed changes.