Page MenuHomePhabricator

Modernize "Author" and "Committer" rendering for commits
ClosedPublic

Authored by epriestley on Jul 10 2020, 4:16 PM.
Tags
None
Referenced Files
F15482200: D21405.id51022.diff
Wed, Apr 9, 3:35 AM
F15441124: D21405.id51022.diff
Wed, Mar 26, 4:31 PM
F15440403: D21405.id50948.diff
Wed, Mar 26, 12:41 PM
F15434467: D21405.id.diff
Tue, Mar 25, 3:53 AM
F15430433: D21405.diff
Mon, Mar 24, 7:39 AM
F15412307: D21405.diff
Wed, Mar 19, 12:21 PM
F15411137: D21405.diff
Wed, Mar 19, 8:51 AM
F15410965: D21405.diff
Wed, Mar 19, 8:44 AM
Subscribers
None

Details

Summary

Ref T13552. Give "Commit" objects a more modern, identity-aware way to render author and committer information.

This uses handles in a more modern way and gives us a single read callsite for raw author and committer names.

Test Plan
  • Grepped for callers to the old methods, found none. (There are a lot of "renderAuthor()" callers in transactions, but this call takes no parameters.)
  • Viewed some commits, saw sensible lists of authors and committers.

Diff Detail

Repository
rP Phabricator
Branch
publish2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24767
Build 34158: Run Core Tests
Build 34157: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2020, 3:58 PM
This revision was automatically updated to reflect the committed changes.