Page MenuHomePhabricator

Modernize "Author" and "Committer" rendering for commits
ClosedPublic

Authored by epriestley on Jul 10 2020, 4:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 20, 11:09 PM
Unknown Object (File)
Feb 20 2024, 9:22 PM
Unknown Object (File)
Feb 19 2024, 7:18 AM
Unknown Object (File)
Feb 8 2024, 6:27 AM
Unknown Object (File)
Jan 18 2024, 11:17 AM
Unknown Object (File)
Jan 6 2024, 11:35 PM
Unknown Object (File)
Dec 24 2023, 3:49 PM
Unknown Object (File)
Dec 18 2023, 6:33 AM
Subscribers
None

Details

Summary

Ref T13552. Give "Commit" objects a more modern, identity-aware way to render author and committer information.

This uses handles in a more modern way and gives us a single read callsite for raw author and committer names.

Test Plan
  • Grepped for callers to the old methods, found none. (There are a lot of "renderAuthor()" callers in transactions, but this call takes no parameters.)
  • Viewed some commits, saw sensible lists of authors and committers.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2020, 3:58 PM
This revision was automatically updated to reflect the committed changes.