Page MenuHomePhabricator

Require rows passed to "loadAllFromArray()" have unique keys
ClosedPublic

Authored by epriestley on Jul 9 2020, 5:56 PM.
Tags
None
Referenced Files
F19823796: D21400.id51039.diff
Sat, Mar 7, 3:26 PM
F19822964: D21400.id51039.diff
Sat, Mar 7, 9:36 AM
F19822198: D21400.id51039.diff
Sat, Mar 7, 3:36 AM
F19822197: D21400.id51039.diff
Sat, Mar 7, 3:35 AM
F19822195: D21400.id51039.diff
Sat, Mar 7, 3:35 AM
F19725808: D21400.id50940.diff
Fri, Feb 13, 4:56 PM
F19362853: D21400.id51039.diff
Dec 26 2025, 10:48 AM
F18974631: D21400.diff
Nov 15 2025, 10:39 PM
Subscribers
None

Details

Summary

See PHI1809, which identified a bug in Project search where queries with a large number of slugs could paginate improperly.

This change detects problems in this category: cases where multiple rows with the same ID are passed to "loadAllFromArray()". It's likely that all cases it detects are cases where a GROUP BY is missing.

Since this might have some false positives or detect some things which aren't fundamentally problematic, I'm planning to hold it until the next release.

Test Plan
  • Reverted D21399, then created a project with multiple slugs and queried for one of them via "project.search". Hit this new exeception.
  • Browsed around a bit, didn't immediately catch any collateral damage.

Diff Detail

Repository
rP Phabricator
Branch
unique1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24759
Build 34145: Run Core Tests
Build 34144: arc lint + arc unit