Differential D21400

Require rows passed to "loadAllFromArray()" have unique keys
ClosedPublic
Actions

Authored by epriestley on Jul 9 2020, 5:56 PM.

Tags

None

Referenced Files

	F15452138: D21400.id51039.diff
	Sat, Mar 29, 2:08 AM

	F15445807: D21400.id.diff
	Thu, Mar 27, 4:08 PM

	F15439708: D21400.diff
	Wed, Mar 26, 9:00 AM

	F15427515: D21400.id50940.diff
	Sun, Mar 23, 2:46 PM

	F15392180: D21400.id.diff
	Sat, Mar 15, 1:37 PM

	F15383422: D21400.diff
	Fri, Mar 14, 4:39 PM

	F15335715: D21400.id51039.diff
	Sat, Mar 8, 5:27 PM

	F15333703: D21400.id50940.diff
	Sat, Mar 8, 4:07 AM

Subscribers

None

Details

Reviewers: None
Commits: rP72f149bf399a: Require rows passed to "loadAllFromArray()" have unique keys

Summary

See PHI1809, which identified a bug in Project search where queries with a large number of slugs could paginate improperly.

This change detects problems in this category: cases where multiple rows with the same ID are passed to "loadAllFromArray()". It's likely that all cases it detects are cases where a GROUP BY is missing.

Since this might have some false positives or detect some things which aren't fundamentally problematic, I'm planning to hold it until the next release.

Test Plan

Reverted D21399, then created a project with multiple slugs and queried for one of them via "project.search". Hit this new exeception.
Browsed around a bit, didn't immediately catch any collateral damage.

Diff Detail

Repository

Branch

unique1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24759
Build 34145: Run Core Tests
Build 34144: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 9 2020, 5:56 PM

Harbormaster completed remote builds in B24759: Diff 50940.Jul 9 2020, 5:58 PM

epriestley requested review of this revision.Jul 9 2020, 5:58 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2020, 4:05 PM

Closed by commit rP72f149bf399a: Require rows passed to "loadAllFromArray()" have unique keys (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP72f149bf399a: Require rows passed to "loadAllFromArray()" have unique keys.

epriestley mentioned this in T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash.Sep 16 2020, 12:16 AM

epriestley mentioned this in D21486: Add a missing "GROUP BY" to MailQuery when querying for multiple recipients.Oct 30 2020, 7:57 PM

epriestley mentioned this in rP671986592baf: Add a missing "GROUP BY" to MailQuery when querying for multiple recipients.Oct 30 2020, 8:02 PM

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

storage/

lisk/

13 lines

Diff 50940

src/infrastructure/storage/lisk/LiskDAO.php

Loading...