Paths

Table of Contentst

Fix a MarkerRef call to get the active bookmark in Mercurial
ClosedPublic
Actions

Authored by epriestley on Jul 6 2020, 9:06 PM.

Tags

None

Referenced Files

	F18867529: D21391.id50918.diff
	Tue, Nov 4, 12:58 AM

	F18778966: D21391.id50918.diff
	Sat, Oct 11, 11:28 AM

	F18744982: D21391.diff
	Oct 3 2025, 4:51 AM

	F18371979: D21391.diff
	Aug 28 2025, 5:53 AM

	F18302695: D21391.diff
	Aug 23 2025, 9:03 PM

	F18101224: D21391.id.diff
	Aug 9 2025, 12:22 PM

	Unknown Object (File)
	Jun 5 2025, 5:02 PM

	Unknown Object (File)
	May 22 2025, 5:19 AM

View All Files

Subscribers

None

Details

Reviewers: None
Commits: rARCe2ac83ce572c: (stable) Fix a MarkerRef call to get the active bookmark in Mercurial
rARC79a6dfd7a99f: Fix a MarkerRef call to get the active bookmark in Mercurial

Summary

See PHI1805. This call is constructed improperly and can lead to a fatal in arc patch under Mercurial.

Test Plan

In Mercurial, ran a valid arc patch operation.

Diff Detail

Repository

rARC Arcanist

Branch

hg1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24737
Build 34114: Run Core Tests
Build 34113: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 6 2020, 9:06 PM

Harbormaster completed remote builds in B24737: Diff 50918.Jul 6 2020, 9:06 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 6 2020, 9:06 PM

epriestley requested review of this revision.

Closed by commit rARC79a6dfd7a99f: Fix a MarkerRef call to get the active bookmark in Mercurial (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC79a6dfd7a99f: Fix a MarkerRef call to get the active bookmark in Mercurial.

epriestley added a commit: rARCe2ac83ce572c: (stable) Fix a MarkerRef call to get the active bookmark in Mercurial.

Revision Contents
Changeset List

Path

Size

src/

repository/

api/

ArcanistMercurialAPI.php

5 lines

Diff 50918

View Options

src/repository/api/ArcanistMercurialAPI.php

Fix a MarkerRef call to get the active bookmark in MercurialClosedPublicActions