Page MenuHomePhabricator

Fix a MarkerRef call to get the active bookmark in Mercurial
ClosedPublic

Authored by epriestley on Jul 6 2020, 9:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 20, 12:27 PM
Unknown Object (File)
Mon, Jan 20, 12:26 PM
Unknown Object (File)
Mon, Jan 20, 12:26 PM
Unknown Object (File)
Sun, Jan 19, 11:36 AM
Unknown Object (File)
Sat, Jan 18, 1:08 AM
Unknown Object (File)
Tue, Jan 7, 8:15 PM
Unknown Object (File)
Sat, Dec 28, 3:06 PM
Unknown Object (File)
Dec 21 2024, 5:04 PM
Subscribers
None

Details

Summary

See PHI1805. This call is constructed improperly and can lead to a fatal in arc patch under Mercurial.

Test Plan

In Mercurial, ran a valid arc patch operation.

Diff Detail

Repository
rARC Arcanist
Branch
hg1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24737
Build 34114: Run Core Tests
Build 34113: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jul 6 2020, 9:06 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.