Page MenuHomePhabricator

Fix a MarkerRef call to get the active bookmark in Mercurial
ClosedPublic

Authored by epriestley on Jul 6 2020, 9:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 26, 10:40 AM
Unknown Object (File)
Wed, Mar 13, 7:37 PM
Unknown Object (File)
Mon, Mar 4, 6:32 AM
Unknown Object (File)
Feb 7 2024, 9:44 PM
Unknown Object (File)
Dec 27 2023, 1:32 PM
Unknown Object (File)
Dec 27 2023, 1:32 PM
Unknown Object (File)
Dec 27 2023, 1:32 PM
Unknown Object (File)
Dec 27 2023, 1:32 PM
Subscribers
None

Details

Summary

See PHI1805. This call is constructed improperly and can lead to a fatal in arc patch under Mercurial.

Test Plan

In Mercurial, ran a valid arc patch operation.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jul 6 2020, 9:06 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.