Page MenuHomePhabricator
Differential D21391

Fix a MarkerRef call to get the active bookmark in Mercurial
ClosedPublic
Actions

Authored by epriestley on Jul 6 2020, 9:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 5:28 PM
Unknown Object (File)
Oct 4 2024, 3:28 AM
Unknown Object (File)
Sep 26 2024, 7:29 PM
Unknown Object (File)
Sep 1 2024, 12:57 PM
Unknown Object (File)
Aug 16 2024, 8:31 PM
Unknown Object (File)
Aug 5 2024, 7:45 PM
Unknown Object (File)
Aug 1 2024, 6:43 PM
Unknown Object (File)
Jul 28 2024, 6:13 PM
View All 85 Files
Subscribers
None

Details

Reviewers
None
Commits
rARCe2ac83ce572c: (stable) Fix a MarkerRef call to get the active bookmark in Mercurial
rARC79a6dfd7a99f: Fix a MarkerRef call to get the active bookmark in Mercurial
Summary

See PHI1805. This call is constructed improperly and can lead to a fatal in arc patch under Mercurial.

Test Plan

In Mercurial, ran a valid arc patch operation.

Diff Detail

Repository
rARC Arcanist
Branch
hg1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24737
Build 34114: Run Core Tests
Build 34113: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 6 2020, 9:06 PM
Harbormaster completed remote builds in B24737: Diff 50918.Jul 6 2020, 9:06 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 6 2020, 9:06 PM
epriestley requested review of this revision.
Closed by commit rARC79a6dfd7a99f: Fix a MarkerRef call to get the active bookmark in Mercurial (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARC79a6dfd7a99f: Fix a MarkerRef call to get the active bookmark in Mercurial.
epriestley added a commit: rARCe2ac83ce572c: (stable) Fix a MarkerRef call to get the active bookmark in Mercurial.

Revision Contents
Changeset List

PathSize
src/
repository/
api/
5 lines

Diff 50918

View Options

src/repository/api/ArcanistMercurialAPI.php

Loading...
Phabricator · Built by Phacility