Page MenuHomePhabricator

Fix a MarkerRef call to get the active bookmark in Mercurial
ClosedPublic

Authored by epriestley on Jul 6 2020, 9:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jun 5 2025, 5:02 PM
Unknown Object (File)
May 22 2025, 5:19 AM
Unknown Object (File)
May 1 2025, 6:48 PM
Unknown Object (File)
Apr 29 2025, 3:33 PM
Unknown Object (File)
Apr 28 2025, 5:44 PM
Unknown Object (File)
Apr 27 2025, 12:05 AM
Unknown Object (File)
Apr 7 2025, 9:47 AM
Unknown Object (File)
Mar 28 2025, 8:16 PM
Subscribers
None

Details

Summary

See PHI1805. This call is constructed improperly and can lead to a fatal in arc patch under Mercurial.

Test Plan

In Mercurial, ran a valid arc patch operation.

Diff Detail

Repository
rARC Arcanist
Branch
hg1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24737
Build 34114: Run Core Tests
Build 34113: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jul 6 2020, 9:06 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.