Page MenuHomePhabricator

Introduce "RepositoryLocalState", a modern version of "requireCleanWorkingCopy()"
ClosedPublic

Authored by epriestley on Jun 5 2020, 12:52 AM.
Tags
None
Referenced Files
F14895824: D21314.id50774.diff
Sun, Feb 9, 9:27 AM
F14895822: D21314.id50732.diff
Sun, Feb 9, 9:27 AM
F14895821: D21314.id.diff
Sun, Feb 9, 9:27 AM
Unknown Object (File)
Fri, Jan 31, 6:07 AM
Unknown Object (File)
Thu, Jan 30, 9:24 PM
Unknown Object (File)
Thu, Jan 30, 1:24 PM
Unknown Object (File)
Thu, Jan 30, 8:40 AM
Unknown Object (File)
Thu, Jan 30, 5:22 AM
Subscribers
None

Details

Summary

Ref T13546. Introduces a more structured construct for saving and restoring local repository state.

This is similar to old behavior, except that:

  • "arc.autostash" is no longer respected;
  • untracked changes are stashed; and
  • we do not offer to amend.
Test Plan

In future changes, saved and restored various permutations of local state.

Diff Detail

Repository
rARC Arcanist
Branch
land8
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/repository/state/ArcanistGitLocalState.php:72XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 24554
Build 33847: Run Core Tests
Build 33846: arc lint + arc unit