Page MenuHomePhabricator

Introduce "RepositoryLocalState", a modern version of "requireCleanWorkingCopy()"
ClosedPublic

Authored by epriestley on Jun 5 2020, 12:52 AM.
Tags
None
Referenced Files
F15470320: D21314.id50732.diff
Fri, Apr 4, 9:33 PM
F15466885: D21314.id50774.diff
Thu, Apr 3, 10:34 AM
F15449810: D21314.id50774.diff
Fri, Mar 28, 12:21 PM
F15425800: D21314.id50774.diff
Sun, Mar 23, 6:08 AM
F15415783: D21314.id50732.diff
Thu, Mar 20, 7:51 AM
F15407140: D21314.diff
Tue, Mar 18, 4:02 PM
F15406200: D21314.id50732.diff
Tue, Mar 18, 12:13 PM
F15403230: D21314.id50774.diff
Tue, Mar 18, 2:20 AM
Subscribers
None

Details

Summary

Ref T13546. Introduces a more structured construct for saving and restoring local repository state.

This is similar to old behavior, except that:

  • "arc.autostash" is no longer respected;
  • untracked changes are stashed; and
  • we do not offer to amend.
Test Plan

In future changes, saved and restored various permutations of local state.

Diff Detail

Repository
rARC Arcanist
Branch
land8
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/repository/state/ArcanistGitLocalState.php:72XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 24554
Build 33847: Run Core Tests
Build 33846: arc lint + arc unit