Page MenuHomePhabricator

Introduce "RepositoryLocalState", a modern version of "requireCleanWorkingCopy()"
ClosedPublic

Authored by epriestley on Jun 5 2020, 12:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 3, 2:00 PM
Unknown Object (File)
Feb 20 2024, 12:01 AM
Unknown Object (File)
Feb 13 2024, 7:52 PM
Unknown Object (File)
Feb 9 2024, 2:12 AM
Unknown Object (File)
Feb 2 2024, 9:23 AM
Unknown Object (File)
Jan 20 2024, 3:12 PM
Unknown Object (File)
Jan 11 2024, 12:42 AM
Unknown Object (File)
Jan 6 2024, 11:35 PM
Subscribers
None

Details

Summary

Ref T13546. Introduces a more structured construct for saving and restoring local repository state.

This is similar to old behavior, except that:

  • "arc.autostash" is no longer respected;
  • untracked changes are stashed; and
  • we do not offer to amend.
Test Plan

In future changes, saved and restored various permutations of local state.

Diff Detail

Repository
rARC Arcanist
Branch
land8
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/repository/state/ArcanistGitLocalState.php:72XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 24554
Build 33847: Run Core Tests
Build 33846: arc lint + arc unit