Page MenuHomePhabricator
Differential D21250

Store inline comment offset information and show it when highlighting comments
ClosedPublic
Actions

Authored by epriestley on May 13 2020, 11:55 PM.
Tags
None
Referenced Files
F19817747: D21250.diff
Thu, Mar 5, 3:16 PM
F19719823: D21250.id.diff
Thu, Feb 12, 7:00 PM
F19603263: D21250.id50605.diff
Feb 3 2026, 7:01 AM
F19513332: D21250.id50605.diff
Jan 13 2026, 11:16 AM
F19513330: D21250.id50605.diff
Jan 13 2026, 11:16 AM
F19103618: D21250.id50605.diff
Dec 5 2025, 11:27 AM
F19034980: D21250.id50605.diff
Nov 25 2025, 3:48 PM
F18964730: D21250.diff
Nov 14 2025, 12:00 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13513: Make schema changes to inlines to prepare for new inline features
Commits
rP2f5398796e02: Store inline comment offset information and show it when highlighting comments
Summary

Ref T13513. When a user selects a text range and uses "New Inline Comment" to create a comment directly from a range, store the offset information alongside the comment.

When hovering the comment, highlight the original range.

Test Plan

character-ranges.gif (712×772 px, 1 MB)

Diff Detail

Repository
rP Phabricator
Branch
engine9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24417
Build 33645: Run Core Tests
Build 33644: arc lint + arc unit

Event Timeline

epriestley created this revision.May 13 2020, 11:55 PM
Harbormaster completed remote builds in B24417: Diff 50600.May 13 2020, 11:56 PM
epriestley requested review of this revision.May 13 2020, 11:56 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 14 2020, 12:21 AM
Closed by commit rP2f5398796e02: Store inline comment offset information and show it when highlighting comments (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP2f5398796e02: Store inline comment offset information and show it when highlighting comments.

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
applications/
celerity/
postprocessor/
2 lines
infrastructure/
diff/
4 lines
interface/
18 lines
view/
2 lines
webroot/
rsrc/
css/
application/
differential/
24 lines
js/
application/
diff/
4 lines
279 lines
49 lines

Diff 50600

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/celerity/postprocessor/CelerityDefaultPostprocessor.php

Loading...
View Options

src/infrastructure/diff/PhabricatorInlineCommentController.php

Loading...
View Options

src/infrastructure/diff/interface/PhabricatorInlineComment.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentView.php

Loading...
View Options

webroot/rsrc/css/application/differential/changeset-view.css

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangeset.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangesetList.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffInline.js

Loading...
Phabricator · Built by Phacility