Store inline comment offset information and show it when highlighting comments
ClosedPublic
Actions

Authored by epriestley on May 13 2020, 11:55 PM.

Details

Reviewers: None
Maniphest Tasks: T13513: Make schema changes to inlines to prepare for new inline features
Commits: rP2f5398796e02: Store inline comment offset information and show it when highlighting comments

Summary

Ref T13513. When a user selects a text range and uses "New Inline Comment" to create a comment directly from a range, store the offset information alongside the comment.

When hovering the comment, highlight the original range.

Test Plan

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 13 2020, 11:55 PM

Harbormaster completed remote builds in B24417: Diff 50600.May 13 2020, 11:56 PM

epriestley requested review of this revision.May 13 2020, 11:56 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 14 2020, 12:21 AM

Closed by commit rP2f5398796e02: Store inline comment offset information and show it when highlighting comments (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP2f5398796e02: Store inline comment offset information and show it when highlighting comments.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

src/

applications/

celerity/

postprocessor/

CelerityDefaultPostprocessor.php

2 lines

infrastructure/

diff/

PhabricatorInlineCommentController.php

4 lines

interface/

PhabricatorInlineComment.php

18 lines

view/

PHUIDiffInlineCommentView.php

2 lines

webroot/

rsrc/

css/

application/

differential/

changeset-view.css

24 lines

js/

application/

diff/

DiffChangeset.js

4 lines

DiffChangesetList.js

279 lines

DiffInline.js

49 lines

Diff 50605

View Options

resources/celerity/map.php

View Options

src/applications/celerity/postprocessor/CelerityDefaultPostprocessor.php

View Options

src/infrastructure/diff/PhabricatorInlineCommentController.php

View Options

src/infrastructure/diff/interface/PhabricatorInlineComment.php

View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentView.php

View Options

webroot/rsrc/css/application/differential/changeset-view.css

View Options

webroot/rsrc/js/application/diff/DiffChangeset.js

View Options

webroot/rsrc/js/application/diff/DiffChangesetList.js

View Options

webroot/rsrc/js/application/diff/DiffInline.js

Store inline comment offset information and show it when highlighting commentsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50605

resources/celerity/map.php

src/applications/celerity/postprocessor/CelerityDefaultPostprocessor.php

src/infrastructure/diff/PhabricatorInlineCommentController.php

src/infrastructure/diff/interface/PhabricatorInlineComment.php

src/infrastructure/diff/view/PHUIDiffInlineCommentView.php

webroot/rsrc/css/application/differential/changeset-view.css

webroot/rsrc/js/application/diff/DiffChangeset.js

webroot/rsrc/js/application/diff/DiffChangesetList.js

webroot/rsrc/js/application/diff/DiffInline.js

Store inline comment offset information and show it when highlighting comments
ClosedPublic
Actions

Revision Contents
Changeset List