Page MenuHomePhabricator

Store inline comment offset information and show it when highlighting comments
ClosedPublic

Authored by epriestley on May 13 2020, 11:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 24, 8:25 PM
Unknown Object (File)
Sun, Mar 24, 8:25 PM
Unknown Object (File)
Sun, Mar 24, 8:25 PM
Unknown Object (File)
Sat, Mar 9, 2:01 PM
Unknown Object (File)
Jan 20 2024, 12:35 PM
Unknown Object (File)
Jan 19 2024, 2:46 PM
Unknown Object (File)
Jan 12 2024, 9:15 AM
Unknown Object (File)
Jan 9 2024, 8:10 AM
Subscribers
None

Details

Summary

Ref T13513. When a user selects a text range and uses "New Inline Comment" to create a comment directly from a range, store the offset information alongside the comment.

When hovering the comment, highlight the original range.

Test Plan

character-ranges.gif (712×772 px, 1 MB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 14 2020, 12:21 AM
This revision was automatically updated to reflect the committed changes.