Page MenuHomePhabricator
Differential D21250

Store inline comment offset information and show it when highlighting comments
ClosedPublic
Actions

Authored by epriestley on May 13 2020, 11:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 10:43 PM
Unknown Object (File)
Sun, Nov 24, 6:43 PM
Unknown Object (File)
Thu, Nov 21, 8:35 AM
Unknown Object (File)
Sun, Nov 17, 10:22 AM
Unknown Object (File)
Thu, Nov 14, 3:27 PM
Unknown Object (File)
Sat, Nov 9, 4:11 PM
Unknown Object (File)
Oct 24 2024, 5:22 AM
Unknown Object (File)
Oct 16 2024, 11:47 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13513: Make schema changes to inlines to prepare for new inline features
Commits
rP2f5398796e02: Store inline comment offset information and show it when highlighting comments
Summary

Ref T13513. When a user selects a text range and uses "New Inline Comment" to create a comment directly from a range, store the offset information alongside the comment.

When hovering the comment, highlight the original range.

Test Plan

character-ranges.gif (712×772 px, 1 MB)

Diff Detail

Repository
rP Phabricator
Branch
engine9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24417
Build 33645: Run Core Tests
Build 33644: arc lint + arc unit

Event Timeline

epriestley created this revision.May 13 2020, 11:55 PM
Harbormaster completed remote builds in B24417: Diff 50600.May 13 2020, 11:56 PM
epriestley requested review of this revision.May 13 2020, 11:56 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 14 2020, 12:21 AM
Closed by commit rP2f5398796e02: Store inline comment offset information and show it when highlighting comments (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP2f5398796e02: Store inline comment offset information and show it when highlighting comments.

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
applications/
celerity/
postprocessor/
2 lines
infrastructure/
diff/
4 lines
interface/
18 lines
view/
2 lines
webroot/
rsrc/
css/
application/
differential/
24 lines
js/
application/
diff/
4 lines
279 lines
49 lines

Diff 50600

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/celerity/postprocessor/CelerityDefaultPostprocessor.php

Loading...
View Options

src/infrastructure/diff/PhabricatorInlineCommentController.php

Loading...
View Options

src/infrastructure/diff/interface/PhabricatorInlineComment.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentView.php

Loading...
View Options

webroot/rsrc/css/application/differential/changeset-view.css

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangeset.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangesetList.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffInline.js

Loading...
Phabricator · Built by Phacility