Don't consider empty inlines when considering whether a revision has draft comments or not
ClosedPublic
Actions

Authored by epriestley on May 4 2020, 5:29 PM.

Details

Reviewers: None
Maniphest Tasks: T13513: Make schema changes to inlines to prepare for new inline features
Commits: rP27b7ba814a5a: Don't consider empty inlines when considering whether a revision has draft…

Summary

Ref T13513. When computing whether a revision has draft comments or not, ignore empty inlines.

Test Plan

Added empty inlines to a revision, no longer saw a yellow "draft" bubble in the list UI.

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

epriestley requested review of this revision.May 4 2020, 5:30 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 4 2020, 8:17 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

src/

applications/

differential/

query/

11 lines