Diffusion Phabricator 27b7ba814a5a

Don't consider empty inlines when considering whether a revision has draft…
27b7ba814a5a
Actions

Tags

None

Referenced Files

None

Subscribers

None

Description

Don't consider empty inlines when considering whether a revision has draft comments or not

Summary: Ref T13513. When computing whether a revision has draft comments or not, ignore empty inlines.

Test Plan: Added empty inlines to a revision, no longer saw a yellow "draft" bubble in the list UI.

Maniphest Tasks: T13513

Differential Revision: https://secure.phabricator.com/D21215

Details

Provenance

epriestley	Authored on May 4 2020, 5:21 PM
epriestley	Pushed on May 4 2020, 8:17 PM

Differential Revision

D21215: Don't consider empty inlines when considering whether a revision has draft comments or not

Parents

rP9307f57747b2: When rendering changesets, discard empty draft inline comments

Branches

Unknown

Tags

Unknown

Tasks

T13513: Make schema changes to inlines to prepare for new inline features

Build Status

Buildable 24345
Build 33537: Run Core Tests

Event Timeline

epriestley committed rP27b7ba814a5a: Don't consider empty inlines when considering whether a revision has draft… (authored by epriestley).May 4 2020, 8:17 PM

epriestley added a task: T13513: Make schema changes to inlines to prepare for new inline features.

epriestley added an edge: D21215: Don't consider empty inlines when considering whether a revision has draft comments or not.

Harbormaster completed building B24345: rP27b7ba814a5a: Don't consider empty inlines when considering whether a revision has draft….May 4 2020, 8:18 PM

Changes (1)

Path

Size

src/

applications/

differential/

query/

DifferentialTransactionQuery.php

rP27b7ba814a5a

src/applications/differential/query/DifferentialTransactionQuery.php

Loading...