D21215.diff
No OneTemporary
Actions

Size

990 B

Referenced Files

None

Subscribers

None

D21215.diff
View Options

	diff --git a/src/applications/differential/query/DifferentialTransactionQuery.php b/src/applications/differential/query/DifferentialTransactionQuery.php
	--- a/src/applications/differential/query/DifferentialTransactionQuery.php
	+++ b/src/applications/differential/query/DifferentialTransactionQuery.php
	@@ -11,7 +11,7 @@
	PhabricatorUser $viewer,
	DifferentialRevision $revision) {

	- return id(new DifferentialDiffInlineCommentQuery())
	+ $inlines = id(new DifferentialDiffInlineCommentQuery())
	->setViewer($viewer)
	->withRevisionPHIDs(array($revision->getPHID()))
	->withAuthorPHIDs(array($viewer->getPHID()))
	@@ -19,6 +19,15 @@
	->withIsDeleted(false)
	->needReplyToComments(true)
	->execute();
	+
	+ // Don't count empty inlines when considering draft state.
	+ foreach ($inlines as $key => $inline) {
	+ if ($inline->isEmptyInlineComment()) {
	+ unset($inlines[$key]);
	+ }
	+ }
	+
	+ return $inlines;
	}

	}