Page MenuHomePhabricator

Don't consider empty inlines when considering whether a revision has draft comments or not
ClosedPublic

Authored by epriestley on May 4 2020, 5:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 11, 11:38 AM
Unknown Object (File)
Feb 9 2024, 1:13 PM
Unknown Object (File)
Feb 5 2024, 3:08 PM
Unknown Object (File)
Dec 28 2023, 5:04 PM
Unknown Object (File)
Dec 24 2023, 3:36 PM
Unknown Object (File)
Dec 22 2023, 10:03 AM
Unknown Object (File)
Dec 16 2023, 2:32 PM
Unknown Object (File)
Dec 16 2023, 9:30 AM
Subscribers
None

Details

Summary

Ref T13513. When computing whether a revision has draft comments or not, ignore empty inlines.

Test Plan

Added empty inlines to a revision, no longer saw a yellow "draft" bubble in the list UI.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 4 2020, 8:17 PM
This revision was automatically updated to reflect the committed changes.