Page MenuHomePhabricator
Differential D21140

Move "External Editor" settings to a separate settings group
ClosedPublic
Actions

Authored by epriestley on Apr 18 2020, 4:56 PM.
Tags
None
Referenced Files
F19241143: D21140.id50350.diff
Sun, Dec 21, 10:22 PM
F19083275: D21140.id50350.diff
Dec 2 2025, 12:33 PM
F18985435: D21140.id50337.diff
Nov 17 2025, 1:02 PM
F18875867: D21140.id.diff
Nov 5 2025, 7:53 PM
F18810407: D21140.id50337.diff
Oct 19 2025, 9:23 PM
F18807313: D21140.diff
Oct 19 2025, 12:35 AM
F18790561: D21140.id50337.diff
Oct 15 2025, 3:32 PM
F18734242: D21140.id.diff
Sep 30 2025, 10:50 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13515: Differential: Inlines and View Options
Commits
rP84cd4a385450: Move "External Editor" settings to a separate settings group
Summary

Ref T13515. It's not intuitive that these settings are "Display Preferences", even thought they're intenrally related to some of the other display preferences.

Give them a separate group.

Test Plan

Screen Shot 2020-04-18 at 9.53.19 AM.png (1×1 px, 335 KB)

Diff Detail

Repository
rP Phabricator
Branch
sticky4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24155
Build 33265: Run Core Tests
Build 33264: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 18 2020, 4:56 PM
Harbormaster completed remote builds in B24155: Diff 50337.Apr 18 2020, 4:57 PM
epriestley requested review of this revision.Apr 18 2020, 4:57 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 19 2020, 3:59 PM
Closed by commit rP84cd4a385450: Move "External Editor" settings to a separate settings group (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP84cd4a385450: Move "External Editor" settings to a separate settings group.

Revision Contents
Changeset List

Diff 50337

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/settings/panel/PhabricatorExternalEditorSettingsPanel.php

Loading...
View Options

src/applications/settings/setting/PhabricatorEditorMultipleSetting.php

Loading...
View Options

src/applications/settings/setting/PhabricatorEditorSetting.php

Loading...
View Options

src/docs/user/userguide/external_editor.diviner

Loading...
Phabricator · Built by Phacility