Page MenuHomePhabricator
Differential D21140

Move "External Editor" settings to a separate settings group
ClosedPublic
Actions

Authored by epriestley on Apr 18 2020, 4:56 PM.
Tags
None
Referenced Files
F15420251: D21140.diff
Fri, Mar 21, 12:34 PM
F15418321: D21140.id50337.diff
Thu, Mar 20, 10:34 PM
F15417283: D21140.id50350.diff
Thu, Mar 20, 4:29 PM
Unknown Object (File)
Wed, Feb 26, 1:38 PM
Unknown Object (File)
Feb 20 2025, 1:37 AM
Unknown Object (File)
Feb 16 2025, 7:39 PM
Unknown Object (File)
Feb 14 2025, 1:56 AM
Unknown Object (File)
Feb 9 2025, 9:01 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13515: Differential: Inlines and View Options
Commits
rP84cd4a385450: Move "External Editor" settings to a separate settings group
Summary

Ref T13515. It's not intuitive that these settings are "Display Preferences", even thought they're intenrally related to some of the other display preferences.

Give them a separate group.

Test Plan

Screen Shot 2020-04-18 at 9.53.19 AM.png (1×1 px, 335 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 18 2020, 4:56 PM
Harbormaster completed remote builds in B24155: Diff 50337.Apr 18 2020, 4:57 PM
epriestley requested review of this revision.Apr 18 2020, 4:57 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 19 2020, 3:59 PM
Closed by commit rP84cd4a385450: Move "External Editor" settings to a separate settings group (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP84cd4a385450: Move "External Editor" settings to a separate settings group.

Revision Contents
Changeset List

Diff 50350

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/settings/panel/PhabricatorExternalEditorSettingsPanel.php

Loading...
View Options

src/applications/settings/setting/PhabricatorEditorMultipleSetting.php

Loading...
View Options

src/applications/settings/setting/PhabricatorEditorSetting.php

Loading...
View Options

src/docs/user/userguide/external_editor.diviner

Loading...
Phabricator · Built by Phacility