Page MenuHomePhabricator
Differential D21140

Move "External Editor" settings to a separate settings group
ClosedPublic
Actions

Authored by epriestley on Apr 18 2020, 4:56 PM.
Tags
None
Referenced Files
F15473074: D21140.id50337.diff
Sat, Apr 5, 7:25 PM
F15447779: D21140.id50350.diff
Fri, Mar 28, 1:30 AM
F15447537: D21140.id50337.diff
Fri, Mar 28, 12:29 AM
F15442072: D21140.id.diff
Wed, Mar 26, 9:11 PM
F15425658: D21140.id.diff
Sun, Mar 23, 5:19 AM
F15420251: D21140.diff
Fri, Mar 21, 12:34 PM
F15418321: D21140.id50337.diff
Thu, Mar 20, 10:34 PM
F15417283: D21140.id50350.diff
Thu, Mar 20, 4:29 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13515: Differential: Inlines and View Options
Commits
rP84cd4a385450: Move "External Editor" settings to a separate settings group
Summary

Ref T13515. It's not intuitive that these settings are "Display Preferences", even thought they're intenrally related to some of the other display preferences.

Give them a separate group.

Test Plan

Screen Shot 2020-04-18 at 9.53.19 AM.png (1×1 px, 335 KB)

Diff Detail

Repository
rP Phabricator
Branch
sticky4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24155
Build 33265: Run Core Tests
Build 33264: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 18 2020, 4:56 PM
Harbormaster completed remote builds in B24155: Diff 50337.Apr 18 2020, 4:57 PM
epriestley requested review of this revision.Apr 18 2020, 4:57 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 19 2020, 3:59 PM
Closed by commit rP84cd4a385450: Move "External Editor" settings to a separate settings group (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP84cd4a385450: Move "External Editor" settings to a separate settings group.

Revision Contents
Changeset List

Diff 50337

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/settings/panel/PhabricatorExternalEditorSettingsPanel.php

Loading...
View Options

src/applications/settings/setting/PhabricatorEditorMultipleSetting.php

Loading...
View Options

src/applications/settings/setting/PhabricatorEditorSetting.php

Loading...
View Options

src/docs/user/userguide/external_editor.diviner

Loading...
Phabricator · Built by Phacility