Page MenuHomePhabricator

Add a "SymbolEngine" to support top-level ref resolution by symbol
ClosedPublic

Authored by epriestley on Apr 12 2020, 6:04 PM.
Tags
None
Referenced Files
F19281820: D21094.diff
Tue, Dec 23, 3:50 AM
F19083248: D21094.id50247.diff
Dec 2 2025, 12:32 PM
F18985405: D21094.id50237.diff
Nov 17 2025, 1:01 PM
F18876542: D21094.id50247.diff
Nov 6 2025, 1:39 AM
F18871516: D21094.id.diff
Nov 4 2025, 11:08 PM
F18867104: D21094.id.diff
Nov 3 2025, 9:33 PM
F18849805: D21094.id50247.diff
Oct 30 2025, 12:21 PM
F18830168: D21094.id.diff
Oct 25 2025, 4:44 AM
Subscribers
None

Details

Summary

Ref T13490. I'm continuing to move toward modernizing "amend", which needs to load some objects by symbol at top level.

Add an API to support this.

Test Plan

Added an API caller to "arc inspect", ran it and hit the new code. Things seemed to work.

Diff Detail

Repository
rARC Arcanist
Branch
aflow9
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/workflow/ArcanistWorkflow.php:2423XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 24055
Build 33118: Run Core Tests
Build 33117: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 12 2020, 8:48 PM
This revision was automatically updated to reflect the committed changes.