Page MenuHomePhabricator

Add a "SymbolEngine" to support top-level ref resolution by symbol
ClosedPublic

Authored by epriestley on Apr 12 2020, 6:04 PM.
Tags
None
Referenced Files
F16609738: D21094.diff
Tue, Jun 17, 7:22 AM
Unknown Object (File)
Fri, May 30, 3:42 AM
Unknown Object (File)
Thu, May 29, 8:12 PM
Unknown Object (File)
Wed, May 28, 8:38 AM
Unknown Object (File)
Tue, May 27, 11:27 PM
Unknown Object (File)
Mon, May 26, 4:22 PM
Unknown Object (File)
Apr 28 2025, 8:35 AM
Unknown Object (File)
Apr 26 2025, 4:53 AM
Subscribers
None

Details

Summary

Ref T13490. I'm continuing to move toward modernizing "amend", which needs to load some objects by symbol at top level.

Add an API to support this.

Test Plan

Added an API caller to "arc inspect", ran it and hit the new code. Things seemed to work.

Diff Detail

Repository
rARC Arcanist
Branch
aflow9
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/workflow/ArcanistWorkflow.php:2423XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 24055
Build 33118: Run Core Tests
Build 33117: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 12 2020, 8:48 PM
This revision was automatically updated to reflect the committed changes.