Page MenuHomePhabricator

Improve error handling in ArcanistRuntime when failing to load libraries
ClosedPublic

Authored by epriestley on Feb 25 2020, 9:50 PM.
Tags
None
Referenced Files
F12859308: D21029.diff
Fri, Mar 29, 12:20 PM
F12849882: D21029.id50095.diff
Fri, Mar 29, 5:01 AM
Unknown Object (File)
Wed, Mar 20, 10:52 PM
Unknown Object (File)
Feb 20 2024, 5:25 AM
Unknown Object (File)
Dec 25 2023, 7:21 PM
Unknown Object (File)
Nov 30 2023, 3:39 AM
Unknown Object (File)
Nov 16 2023, 3:14 PM
Unknown Object (File)
Nov 13 2023, 5:03 AM
Subscribers
None

Details

Summary

Ref T13490. This fixes one bug in D21025 (loading relative to "arcanist/" rather than the parent directory) and improves behavior when a library fails to load (we prompt the user to continue).

Test Plan
  • Ran arc list with bad library specifications, got a sensible error and an option to continue.
  • Ran arc list with a library specification that existed next to "arcanist/", got a library load instead of an error.

Diff Detail

Repository
rARC Arcanist
Branch
load1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23917
Build 32911: Run Core Tests
Build 32910: arc lint + arc unit