Page MenuHomePhabricator

Improve error handling in ArcanistRuntime when failing to load libraries
ClosedPublic

Authored by epriestley on Feb 25 2020, 9:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 25, 9:53 PM
Unknown Object (File)
Sat, Jun 25, 5:15 AM
Unknown Object (File)
Sun, Jun 19, 3:29 AM
Unknown Object (File)
Sat, Jun 11, 11:27 PM
Unknown Object (File)
Thu, Jun 9, 9:53 PM
Unknown Object (File)
Fri, Jun 3, 1:47 PM
Subscribers
None

Details

Summary

Ref T13490. This fixes one bug in D21025 (loading relative to "arcanist/" rather than the parent directory) and improves behavior when a library fails to load (we prompt the user to continue).

Test Plan
  • Ran arc list with bad library specifications, got a sensible error and an option to continue.
  • Ran arc list with a library specification that existed next to "arcanist/", got a library load instead of an error.

Diff Detail

Repository
rARC Arcanist
Branch
load1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23917
Build 32911: Run Core Tests
Build 32910: arc lint + arc unit