Page MenuHomePhabricator

Improve error handling in ArcanistRuntime when failing to load libraries
ClosedPublic

Authored by epriestley on Feb 25 2020, 9:50 PM.
Tags
None
Referenced Files
F15469584: D21029.id50096.diff
Fri, Apr 4, 2:55 PM
F15458233: D21029.id50095.diff
Sun, Mar 30, 10:02 PM
F15439262: D21029.id50096.diff
Wed, Mar 26, 6:38 AM
F15434621: D21029.id.diff
Tue, Mar 25, 4:41 AM
F15433612: D21029.id50095.diff
Tue, Mar 25, 12:01 AM
F15430519: D21029.diff
Mon, Mar 24, 8:01 AM
F15413832: D21029.diff
Wed, Mar 19, 9:35 PM
Unknown Object (File)
Mar 1 2025, 8:36 PM
Subscribers
None

Details

Summary

Ref T13490. This fixes one bug in D21025 (loading relative to "arcanist/" rather than the parent directory) and improves behavior when a library fails to load (we prompt the user to continue).

Test Plan
  • Ran arc list with bad library specifications, got a sensible error and an option to continue.
  • Ran arc list with a library specification that existed next to "arcanist/", got a library load instead of an error.

Diff Detail

Repository
rARC Arcanist
Branch
load1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23917
Build 32911: Run Core Tests
Build 32910: arc lint + arc unit