Paths

Table of Contentst

Differential D21029

Improve error handling in ArcanistRuntime when failing to load libraries
ClosedPublic
Actions

Authored by epriestley on Feb 25 2020, 9:50 PM.

Tags

None

Referenced Files

	F15549382: D21029.id50096.diff
	Sun, Apr 27, 5:24 AM

	F15544235: D21029.id.diff
	Sat, Apr 26, 3:44 AM

	F15540254: D21029.diff
	Fri, Apr 25, 6:56 AM

	F15539613: D21029.id50095.diff
	Fri, Apr 25, 2:59 AM

	F15539203: D21029.diff
	Fri, Apr 25, 12:07 AM

	F15517963: D21029.id50095.diff
	Sat, Apr 19, 9:50 AM

	F15473064: D21029.id50095.diff
	Sat, Apr 5, 7:23 PM

	F15469584: D21029.id50096.diff
	Fri, Apr 4, 2:55 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13490: Upgrade all "classic" Arcanist workflows to Toolsets
Commits: rARC9bd5c23b2a3e: Improve error handling in ArcanistRuntime when failing to load libraries

Summary

Ref T13490. This fixes one bug in D21025 (loading relative to "arcanist/" rather than the parent directory) and improves behavior when a library fails to load (we prompt the user to continue).

Test Plan

Ran arc list with bad library specifications, got a sensible error and an option to continue.
Ran arc list with a library specification that existed next to "arcanist/", got a library load instead of an error.

Diff Detail

Repository

Branch

load1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23917
Build 32911: Run Core Tests
Build 32910: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 25 2020, 9:50 PM

epriestley mentioned this in rARC9cd72baae92c: Update Phage for toolsets and restore library loading behaviors.Feb 25 2020, 9:50 PM

Harbormaster completed remote builds in B23917: Diff 50095.Feb 25 2020, 9:51 PM

epriestley requested review of this revision.Feb 25 2020, 9:51 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 25 2020, 10:07 PM

Closed by commit rARC9bd5c23b2a3e: Improve error handling in ArcanistRuntime when failing to load libraries (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC9bd5c23b2a3e: Improve error handling in ArcanistRuntime when failing to load libraries.

Revision Contents
Changeset List

Path

Size

src/

init/

lib/

PhutilBootloader.php

4 lines

moduleutils.php

2 lines

runtime/

ArcanistRuntime.php

66 lines

Diff 50095

src/init/lib/PhutilBootloader.php

Loading...

src/init/lib/moduleutils.php

Loading...

src/runtime/ArcanistRuntime.php

Loading...