Page MenuHomePhabricator

Add more layout constraints to tokenizer CSS to prevent layout issues with Chinese glyphs in Firefox 73
ClosedPublic

Authored by epriestley on Feb 24 2020, 3:47 PM.
Tags
None
Referenced Files
F15414102: D21026.id50090.diff
Wed, Mar 19, 11:11 PM
F15399549: D21026.diff
Mon, Mar 17, 5:07 AM
F15337023: D21026.diff
Sun, Mar 9, 3:39 AM
F15336147: D21026.id50090.diff
Sat, Mar 8, 6:18 PM
F15336146: D21026.diff
Sat, Mar 8, 6:18 PM
Unknown Object (File)
Feb 9 2025, 8:46 AM
Unknown Object (File)
Feb 9 2025, 8:46 AM
Unknown Object (File)
Feb 9 2025, 8:45 AM
Subscribers
None

Details

Summary

Fixes T13495. See that task for details.

Tokenizer tokens which contain Chinese glyphs are slightly taller than normal tokens in Firefox 73, and at some non-100% zoom levels in other browsers.

This cauess the tokenizer list to layout and line break oddly.

Fix this by clamping tokenizer sizes more aggressively. Specifying a max-height means they can no longer line wrap, so this also requires more specification of overflow behavior.

Test Plan

Before:

Screen Shot 2020-02-24 at 7.27.06 AM.png (83×723 px, 17 KB)

After:

Screen Shot 2020-02-24 at 7.44.47 AM.png (69×264 px, 10 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 24 2020, 4:00 PM
This revision was automatically updated to reflect the committed changes.