Page MenuHomePhabricator

Add more layout constraints to tokenizer CSS to prevent layout issues with Chinese glyphs in Firefox 73
ClosedPublic

Authored by epriestley on Feb 24 2020, 3:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 7:31 AM
Unknown Object (File)
Sun, Apr 7, 7:33 AM
Unknown Object (File)
Mon, Apr 1, 9:07 PM
Unknown Object (File)
Wed, Mar 27, 8:42 AM
Unknown Object (File)
Mar 23 2024, 12:50 PM
Unknown Object (File)
Mar 14 2024, 6:07 PM
Unknown Object (File)
Mar 10 2024, 3:49 PM
Unknown Object (File)
Dec 25 2023, 2:04 PM
Subscribers
None

Details

Summary

Fixes T13495. See that task for details.

Tokenizer tokens which contain Chinese glyphs are slightly taller than normal tokens in Firefox 73, and at some non-100% zoom levels in other browsers.

This cauess the tokenizer list to layout and line break oddly.

Fix this by clamping tokenizer sizes more aggressively. Specifying a max-height means they can no longer line wrap, so this also requires more specification of overflow behavior.

Test Plan

Before:

Screen Shot 2020-02-24 at 7.27.06 AM.png (83×723 px, 17 KB)

After:

Screen Shot 2020-02-24 at 7.44.47 AM.png (69×264 px, 10 KB)

Diff Detail

Repository
rP Phabricator
Branch
glyph1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23911
Build 32902: Run Core Tests
Build 32901: arc lint + arc unit

Unit TestsFailed

TimeTest
543 msPhabricatorCelerityTestCase::testCelerityMaps
Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:32): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it. ACTUAL VALUE
0 msAlmanacNamesTestCase::testServiceOrDeviceNames
30 assertions passed.
0 msAlmanacServiceTypeTestCase::testGetAllServiceTypes
1 assertion passed.
0 msAphrontHTTPHeaderParserTestCase::testHeaderParser
18 assertions passed.
0 msAphrontHTTPSinkTestCase::testHTTPHeaderNames
2 assertions passed.
View Full Test Results (1 Failed · 418 Passed · 2 Skipped)

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 24 2020, 4:00 PM
This revision was automatically updated to reflect the committed changes.