Page MenuHomePhabricator

Add more layout constraints to tokenizer CSS to prevent layout issues with Chinese glyphs in Firefox 73
ClosedPublic

Authored by epriestley on Feb 24 2020, 3:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 27, 8:42 AM
Unknown Object (File)
Sat, Mar 23, 12:50 PM
Unknown Object (File)
Thu, Mar 14, 6:07 PM
Unknown Object (File)
Sun, Mar 10, 3:49 PM
Unknown Object (File)
Dec 25 2023, 2:04 PM
Unknown Object (File)
Dec 21 2023, 7:58 PM
Unknown Object (File)
Dec 13 2023, 6:24 PM
Unknown Object (File)
Nov 30 2023, 5:43 AM
Subscribers
None

Details

Summary

Fixes T13495. See that task for details.

Tokenizer tokens which contain Chinese glyphs are slightly taller than normal tokens in Firefox 73, and at some non-100% zoom levels in other browsers.

This cauess the tokenizer list to layout and line break oddly.

Fix this by clamping tokenizer sizes more aggressively. Specifying a max-height means they can no longer line wrap, so this also requires more specification of overflow behavior.

Test Plan

Before:

Screen Shot 2020-02-24 at 7.27.06 AM.png (83×723 px, 17 KB)

After:

Screen Shot 2020-02-24 at 7.44.47 AM.png (69×264 px, 10 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 24 2020, 4:00 PM
This revision was automatically updated to reflect the committed changes.