Page MenuHomePhabricator

In Git, fall back across versions more cleanly when trying to get the URI for a remote
ClosedPublic

Authored by epriestley on Jan 23 2020, 11:17 PM.
Tags
None
Referenced Files
F19545484: D20950.id49913.diff
Jan 24 2026, 8:11 AM
F19542608: D20950.id49914.diff
Jan 22 2026, 10:36 AM
F19542490: D20950.id49913.diff
Jan 22 2026, 10:05 AM
F19523684: D20950.id.diff
Jan 17 2026, 6:40 PM
F19521716: D20950.diff
Jan 17 2026, 12:59 AM
F19131149: D20950.diff
Dec 10 2025, 5:52 AM
F19083147: D20950.id49914.diff
Dec 2 2025, 12:31 PM
F18985313: D20950.id49913.diff
Nov 17 2025, 12:58 PM
Subscribers
None

Details

Summary

Fixes T13481. When identifying the URI for a remote, fall back from "git remote get-url" to "git ls-remote --get-url" to "git config remote.<name>.url" based on command output and version tests.

Test Plan

Ran arc land --hold, rigged the subcommands to fail to try all three fallbacks, ran arc land --hold --remote asdfasdf to get an explicit failure.

Diff Detail

Repository
rARC Arcanist
Branch
push1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23739
Build 32645: Run Core Tests
Build 32644: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jan 23 2020, 11:18 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.