In Git, fall back across versions more cleanly when trying to get the URI for a remote
ClosedPublic
Actions

Authored by epriestley on Jan 23 2020, 11:17 PM.

Details

Reviewers: None
Maniphest Tasks: T13481: Don't require "git remote get-url" in Arcanist
Commits: rARC70c0fd3f2233: In Git, fall back across versions more cleanly when trying to get the URI for a…

Summary

Fixes T13481. When identifying the URI for a remote, fall back from "git remote get-url" to "git ls-remote --get-url" to "git config remote.<name>.url" based on command output and version tests.

Test Plan

Ran arc land --hold, rigged the subcommands to fail to try all three fallbacks, ran arc land --hold --remote asdfasdf to get an explicit failure.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 23 2020, 11:17 PM

Harbormaster completed remote builds in B23739: Diff 49913.Jan 23 2020, 11:18 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 23 2020, 11:18 PM

epriestley requested review of this revision.

Closed by commit rARC70c0fd3f2233: In Git, fall back across versions more cleanly when trying to get the URI for a… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC70c0fd3f2233: In Git, fall back across versions more cleanly when trying to get the URI for a….

Revision Contents
Changeset List

Path

Size

src/

repository/

api/

ArcanistGitAPI.php

126 lines

Diff 49914

View Options

src/repository/api/ArcanistGitAPI.php

In Git, fall back across versions more cleanly when trying to get the URI for a remoteClosedPublicActions