Page MenuHomePhabricator

In Git, fall back across versions more cleanly when trying to get the URI for a remote
ClosedPublic

Authored by epriestley on Jan 23 2020, 11:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 3, 3:01 AM
Unknown Object (File)
Thu, Mar 28, 9:38 PM
Unknown Object (File)
Wed, Mar 27, 5:50 PM
Unknown Object (File)
Jan 6 2024, 5:03 AM
Unknown Object (File)
Dec 23 2023, 9:41 PM
Unknown Object (File)
Dec 13 2023, 1:48 PM
Unknown Object (File)
Dec 12 2023, 11:17 PM
Unknown Object (File)
Nov 30 2023, 4:48 AM
Subscribers
None

Details

Summary

Fixes T13481. When identifying the URI for a remote, fall back from "git remote get-url" to "git ls-remote --get-url" to "git config remote.<name>.url" based on command output and version tests.

Test Plan

Ran arc land --hold, rigged the subcommands to fail to try all three fallbacks, ran arc land --hold --remote asdfasdf to get an explicit failure.

Diff Detail

Repository
rARC Arcanist
Branch
push1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23739
Build 32645: Run Core Tests
Build 32644: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jan 23 2020, 11:18 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.