Page MenuHomePhabricator

Fix an issue where any diff which could possibly be rendered as Jupyter decided to render as Jupyter
ClosedPublic

Authored by epriestley on Oct 2 2019, 1:50 AM.
Tags
None
Referenced Files
F13189194: D20850.diff
Sat, May 11, 5:46 AM
Unknown Object (File)
Mon, May 6, 4:28 PM
Unknown Object (File)
Sat, May 4, 8:52 PM
Unknown Object (File)
Fri, May 3, 1:42 PM
Unknown Object (File)
Wed, Apr 24, 11:38 PM
Unknown Object (File)
Wed, Apr 24, 10:44 PM
Unknown Object (File)
Apr 7 2024, 4:21 AM
Unknown Object (File)
Apr 7 2024, 3:09 AM
Subscribers
None

Details

Summary

See PHI1468. Engine selection for diffs is currently too aggressive in trying to find a shared engine and will fall back a shared engine with a very low score, causing all ".json" files to render as Jupyter files.

Only pick an engine as a difference engine by default if it's the highest-scoring engine for the new file.

Test Plan

Viewed ".json" files and ".ipynb" files in a revision. Before, both rendered as Jupyter. Now, the former rendered as JSON and the latter rendered as Jupyter.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable