Page MenuHomePhabricator

Fix an issue where any diff which could possibly be rendered as Jupyter decided to render as Jupyter
ClosedPublic

Authored by epriestley on Oct 2 2019, 1:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 6, 5:15 AM
Unknown Object (File)
Mon, May 5, 7:51 PM
Unknown Object (File)
Apr 10 2025, 7:06 AM
Unknown Object (File)
Apr 8 2025, 10:26 PM
Unknown Object (File)
Apr 8 2025, 10:26 PM
Unknown Object (File)
Apr 8 2025, 10:26 PM
Unknown Object (File)
Apr 7 2025, 5:33 PM
Unknown Object (File)
Apr 4 2025, 6:15 AM
Subscribers
None

Details

Summary

See PHI1468. Engine selection for diffs is currently too aggressive in trying to find a shared engine and will fall back a shared engine with a very low score, causing all ".json" files to render as Jupyter files.

Only pick an engine as a difference engine by default if it's the highest-scoring engine for the new file.

Test Plan

Viewed ".json" files and ".ipynb" files in a revision. Before, both rendered as Jupyter. Now, the former rendered as JSON and the latter rendered as Jupyter.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable