Page MenuHomePhabricator

Fix an issue where any diff which could possibly be rendered as Jupyter decided to render as Jupyter
ClosedPublic

Authored by epriestley on Oct 2 2019, 1:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 7, 4:21 AM
Unknown Object (File)
Sun, Apr 7, 3:09 AM
Unknown Object (File)
Mar 10 2024, 3:10 PM
Unknown Object (File)
Feb 11 2024, 2:15 PM
Unknown Object (File)
Feb 9 2024, 5:11 PM
Unknown Object (File)
Feb 7 2024, 11:36 PM
Unknown Object (File)
Jan 21 2024, 6:49 PM
Unknown Object (File)
Jan 21 2024, 12:58 PM
Subscribers
None

Details

Summary

See PHI1468. Engine selection for diffs is currently too aggressive in trying to find a shared engine and will fall back a shared engine with a very low score, causing all ".json" files to render as Jupyter files.

Only pick an engine as a difference engine by default if it's the highest-scoring engine for the new file.

Test Plan

Viewed ".json" files and ".ipynb" files in a revision. Before, both rendered as Jupyter. Now, the former rendered as JSON and the latter rendered as Jupyter.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable