Page MenuHomePhabricator

Fix an issue where any diff which could possibly be rendered as Jupyter decided to render as Jupyter
ClosedPublic

Authored by epriestley on Oct 2 2019, 1:50 AM.
Tags
None
Referenced Files
F14406805: D20850.diff
Mon, Dec 23, 8:25 PM
Unknown Object (File)
Fri, Dec 20, 3:50 AM
Unknown Object (File)
Wed, Nov 27, 4:06 PM
Unknown Object (File)
Wed, Nov 27, 1:46 PM
Unknown Object (File)
Tue, Nov 26, 11:55 AM
Unknown Object (File)
Nov 9 2024, 3:53 PM
Unknown Object (File)
Oct 21 2024, 9:02 AM
Unknown Object (File)
Oct 18 2024, 12:40 AM
Subscribers
None

Details

Summary

See PHI1468. Engine selection for diffs is currently too aggressive in trying to find a shared engine and will fall back a shared engine with a very low score, causing all ".json" files to render as Jupyter files.

Only pick an engine as a difference engine by default if it's the highest-scoring engine for the new file.

Test Plan

Viewed ".json" files and ".ipynb" files in a revision. Before, both rendered as Jupyter. Now, the former rendered as JSON and the latter rendered as Jupyter.

Diff Detail

Repository
rP Phabricator
Branch
dtype1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23531
Build 32339: Run Core Tests
Build 32338: arc lint + arc unit