Differential D20844

Make basic Juypter notebook rendering improvements and roughly support folding unchanged context
ClosedPublic
Actions

Authored by epriestley on Sep 27 2019, 9:31 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, May 6, 9:51 AM

	Unknown Object (File)
	Thu, May 1, 4:36 AM

	Unknown Object (File)
	Mon, Apr 28, 9:56 PM

	Unknown Object (File)
	Sun, Apr 27, 8:41 AM

	Unknown Object (File)
	Sat, Apr 19, 1:22 PM

	Unknown Object (File)
	Tue, Apr 15, 5:47 AM

	Unknown Object (File)
	Mar 30 2025, 8:24 PM

	Unknown Object (File)
	Mar 30 2025, 4:48 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13425: Support diffs between abstract block lists in the UI
Commits: rP5afdc620db59: Make basic Juypter notebook rendering improvements and roughly support folding…

Summary

Depends on D20843. Ref T13425. Add very basic support for "Show Hidden Context", in the form of folding it behind an unclickable shield. This isn't ideal, but should be better than nothing.

Prepare for "intraline" diffs on content blocks.

Fix newline handling in Markdown sections in Jupyter notebooks.

Remove the word "visibile" from the codebase.

Test Plan

Screen Shot 2019-09-27 at 2.31.02 PM.png (435×1 px, 84 KB)

Diff Detail

Repository

Branch

jupyter2

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/files/diff/PhabricatorDocumentEngineBlocks.php:70	XHP16	TODO Comment
Advice	src/applications/files/document/PhabricatorJupyterDocumentEngine.php:332	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 23515
Build 32318: Run Core Tests
Build 32317: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 27 2019, 9:31 PM

Harbormaster completed remote builds in B23515: Diff 49688.Sep 27 2019, 9:33 PM

epriestley requested review of this revision.Sep 27 2019, 9:33 PM

epriestley added a child revision: D20845: Perform basic block interdiffs when diffing abstract blocks, and interdiff markdown in Jupyter notebooks.Sep 28 2019, 12:25 AM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 30 2019, 5:41 PM

Closed by commit rP5afdc620db59: Make basic Juypter notebook rendering improvements and roughly support folding… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP5afdc620db59: Make basic Juypter notebook rendering improvements and roughly support folding….

Revision Contents
Changeset List

Path

Size

resources/

celerity/

src/

applications/

differential/

parser/

DifferentialChangesetParser.php

6 lines

DifferentialHunkParser.php

4 lines

render/

DifferentialChangesetTwoUpRenderer.php

65 lines

files/

diff/

PhabricatorDocumentEngineBlock.php

10 lines

PhabricatorDocumentEngineBlocks.php

13 lines

document/

PhabricatorJupyterDocumentEngine.php

27 lines

paste/

query/

PhabricatorPasteQuery.php

18 lines

webroot/

rsrc/

css/

phui/

phui-property-list-view.css

14 lines

Diff 49688

resources/celerity/map.php

Loading...

src/applications/differential/parser/DifferentialChangesetParser.php

Loading...

src/applications/differential/parser/DifferentialHunkParser.php

Loading...

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

Loading...

src/applications/files/diff/PhabricatorDocumentEngineBlock.php

Loading...

src/applications/files/diff/PhabricatorDocumentEngineBlocks.php

Loading...

src/applications/files/document/PhabricatorJupyterDocumentEngine.php

Loading...

src/applications/paste/query/PhabricatorPasteQuery.php

Loading...

webroot/rsrc/css/phui/phui-property-list-view.css

Loading...