Page MenuHomePhabricator

Improve rendering of Herald rules in "Another Herald rule..." field
ClosedPublic

Authored by epriestley on Sep 9 2019, 8:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 9 2024, 3:18 AM
Unknown Object (File)
Jan 25 2024, 6:04 AM
Unknown Object (File)
Jan 22 2024, 2:16 PM
Unknown Object (File)
Jan 22 2024, 2:15 PM
Unknown Object (File)
Dec 28 2023, 11:03 AM
Unknown Object (File)
Dec 23 2023, 1:17 AM
Unknown Object (File)
Dec 13 2023, 12:08 PM
Unknown Object (File)
Nov 30 2023, 5:03 AM
Subscribers
None

Details

Summary

Fixes T9136.

  • Fix a bug where the name is rendered improperly.
  • Put disabled rules at the bottom.
  • Always show the rule monogram so you can distingiush between rules with the same name.
Test Plan

Screen Shot 2019-09-09 at 1.24.21 PM.png (274×704 px, 50 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 9 2019, 8:29 PM
This revision was automatically updated to reflect the committed changes.