Page MenuHomePhabricator

Improve rendering of Herald rules in "Another Herald rule..." field
ClosedPublic

Authored by epriestley on Sep 9 2019, 8:25 PM.

Details

Summary

Fixes T9136.

  • Fix a bug where the name is rendered improperly.
  • Put disabled rules at the bottom.
  • Always show the rule monogram so you can distingiush between rules with the same name.
Test Plan

Diff Detail

Repository
rP Phabricator
Branch
herald3
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 23416
Build 32169: Run Core Tests
Build 32168: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 9 2019, 8:29 PM
This revision was automatically updated to reflect the committed changes.