Page MenuHomePhabricator

Allow repository service lookups to return an ordered list of service refs
ClosedPublic

Authored by epriestley on Sep 3 2019, 3:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 28, 5:21 AM
Unknown Object (File)
Sat, Jan 25, 5:37 AM
Unknown Object (File)
Sat, Jan 25, 5:37 AM
Unknown Object (File)
Sat, Jan 25, 5:37 AM
Unknown Object (File)
Fri, Jan 24, 6:14 PM
Unknown Object (File)
Thu, Jan 23, 10:27 PM
Unknown Object (File)
Tue, Jan 21, 9:30 AM
Unknown Object (File)
Mon, Jan 20, 12:10 PM
Subscribers
None

Details

Summary

Ref T13286. To support request retries, allow the service lookup method to return an ordered list of structured service references.

Existing callsites continue to immediately discard all but the first reference and pull a URI out of it.

Test Plan

Ran git pull in a clustered repository with an "up" node and a "down" node, saw 50% serivce failures and 50% clean pulls.

Diff Detail

Repository
rP Phabricator
Branch
fallback1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23363
Build 32091: Run Core Tests
Build 32090: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 3 2019, 5:05 PM
This revision was automatically updated to reflect the committed changes.
src/applications/repository/storage/PhabricatorRepository.php
1980

This variable should have been renamed. See T13611.