Page MenuHomePhabricator

Fix two minor display issues with the Conduit "*.search" API documentation
ClosedPublic

Authored by epriestley on Jul 31 2019, 6:22 PM.
Tags
None
Referenced Files
F15412722: D20686.id49339.diff
Wed, Mar 19, 2:37 PM
F15393622: D20686.diff
Sat, Mar 15, 10:53 PM
F15381009: D20686.id.diff
Fri, Mar 14, 5:28 AM
F15375474: D20686.diff
Wed, Mar 12, 11:24 PM
Unknown Object (File)
Tue, Feb 25, 8:53 AM
Unknown Object (File)
Tue, Feb 25, 3:05 AM
Unknown Object (File)
Mon, Feb 24, 2:37 PM
Unknown Object (File)
Feb 5 2025, 7:19 AM
Subscribers
None

Details

Summary

Depends on D20685. Ref T13350. Currently:

  • When a SearchEngine parameter is marked as hidden from Conduit, we may still render a table of possible values. Instead, only render the table if the parameter is actually usable.
  • The table header is hard-coded to say 'statuses', which is just a silly mistake. (Most commonly, this table does have statuses constants.)
Test Plan

Viewed the Conduit API documentation for the new "slowvote.poll.search" API method, saw more sensible display behavior.

Diff Detail

Repository
rP Phabricator
Branch
vapi2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23200
Build 31867: Run Core Tests
Build 31866: arc lint + arc unit