Page MenuHomePhabricator

Fix two minor display issues with the Conduit "*.search" API documentation
ClosedPublic

Authored by epriestley on Jul 31 2019, 6:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 4, 4:15 AM
Unknown Object (File)
Tue, Jan 31, 9:56 PM
Unknown Object (File)
Sun, Jan 29, 12:16 AM
Unknown Object (File)
Tue, Jan 24, 1:54 PM
Unknown Object (File)
Sat, Jan 21, 3:55 AM
Unknown Object (File)
Thu, Jan 19, 3:07 PM
Unknown Object (File)
Thu, Jan 19, 3:07 PM
Unknown Object (File)
Thu, Jan 19, 11:55 AM
Subscribers
None

Details

Summary

Depends on D20685. Ref T13350. Currently:

  • When a SearchEngine parameter is marked as hidden from Conduit, we may still render a table of possible values. Instead, only render the table if the parameter is actually usable.
  • The table header is hard-coded to say 'statuses', which is just a silly mistake. (Most commonly, this table does have statuses constants.)
Test Plan

Viewed the Conduit API documentation for the new "slowvote.poll.search" API method, saw more sensible display behavior.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable